Skip to content

Align dma_stream helper structure with mainline#617

Open
Je5s1e wants to merge 2 commits into
asterinas:mainfrom
Je5s1e:align/dma_stream
Open

Align dma_stream helper structure with mainline#617
Je5s1e wants to merge 2 commits into
asterinas:mainfrom
Je5s1e:align/dma_stream

Conversation

@Je5s1e

@Je5s1e Je5s1e commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@hiroki-chen

Copy link
Copy Markdown
Collaborator

Please explain why is the snapshot for DmaStreamInner is justified:

  • Why is better than wrapper method using rwarc locks?
  • Who will provide the snapshot? Who tracks it? Who ensures that the snapshot is "the" current state of the dma stream?

To me this looks unsound.

@hiroki-chen

Copy link
Copy Markdown
Collaborator

Please explain why is the snapshot for DmaStreamInner is justified:

  • Why is better than wrapper method using rwarc locks?
  • Who will provide the snapshot? Who tracks it? Who ensures that the snapshot is "the" current state of the dma stream?

To me this looks unsound.

On a sidenote this design is intentional because tracking the runtime properties via RwArc is not well-supported. Maintaining the invariant without reasoning about how invariant mutates provides little verification meanings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants