Skip to content

channels/pjsip: Add tests for SIP MESSAGE redirect functionality #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
github-actions merged 1 commit into from
Jan 7, 2026
Merged

channels/pjsip: Add tests for SIP MESSAGE redirect functionality #117

github-actions merged 1 commit into from
Jan 7, 2026

Conversation

@maximilianfridrich
Copy link
Contributor

@maximilianfridrich maximilianfridrich commented Nov 7, 2025 •
edited
Loading

This commit adds comprehensive test coverage for SIP MESSAGE redirect handling with 305 Use Proxy responses in Asterisk's PJSIP stack.

Test coverage includes:

  • Basic MESSAGE redirect with follow_redirect_methods=message configured
  • Verification that redirects are NOT followed when follow_redirect_methods is unset
  • Multiple Contact header handling with q-value priority
  • Contact failover when higher-priority contacts reject (4xx responses)
  • Redirect loop detection and prevention

github-actions[bot]
github-actions bot previously requested changes Nov 7, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Checklist Complete

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Workflow PRCheck failed
master-gates: FAILED TEST: channels/pjsip/message/message_redirect
master-gates: FAILED TEST: channels/pjsip/message/message_redirect_multiple

@maximilianfridrich
Copy link
Contributor Author

maximilianfridrich commented Nov 7, 2025 •
edited
Loading

The two new message/message_redirect* tests that failed are exactly the ones that I would expect to fail without the new Asterisk improvement. The tests pass in the corresponding Asterisk PR with the redirect improvement which uses this testsuite PR: asterisk/asterisk#1580 (link to corresponding job).

@maximilianfridrich
Copy link
Contributor Author

maximilianfridrich commented Nov 7, 2025 •
edited by gtjoseph
Loading

cherry-pick-to: 20
cherry-pick-to: 22
cherry-pick-to: 23

@gtjoseph
Copy link
Member

gtjoseph commented Nov 7, 2025

I probably forgot to announce this but you can now add asterisk-test-pr: <pr> to testsuite PRs just like you added testsuite-test-pr to your asterisk PR. I'll update your comment.

@github-actions github-actions bot dismissed their stale review November 7, 2025 13:52

Pull Request Checklist Complete

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Workflow PRCheck completed successfully

@maximilianfridrich
channels/pjsip: Add tests for SIP MESSAGE redirect functionality
a5437ba 
This commit adds comprehensive test coverage for SIP MESSAGE redirect
handling with 305 Use Proxy responses in Asterisk's PJSIP stack.

Test coverage includes:
- Basic MESSAGE redirect with follow_redirect_methods=message configured
- Verification that redirects are NOT followed when
  follow_redirect_methods is unset
- Multiple Contact header handling with q-value priority
- Contact failover when higher-priority contacts reject (4xx responses)
- Redirect loop detection and prevention
@maximilianfridrich
Copy link
Contributor Author

maximilianfridrich commented Dec 12, 2025

Updated in accordance with the Asterisk PR - the redirect feature is now configured using the new pjsip endpoint option follow_redirect_methods.

github-actions[bot]

This comment was marked as resolved.

Sign in to view

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

Workflow PRCheck completed successfully

@maximilianfridrich
Copy link
Contributor Author

maximilianfridrich commented Jan 7, 2026

@gtjoseph Do you think this PR could be merged? The corresponding Asterisk PR has been merged.

@github-actions github-actions bot added the cherry-pick-testing-in-progress Cherry-Pick tests in progress label Jan 7, 2026
@gtjoseph
Copy link
Member

gtjoseph commented Jan 7, 2026

@gtjoseph Do you think this PR could be merged? The corresponding Asterisk PR has been merged.

Yeah sorry. I really need to set up the scripts so that the testsuite PR automatically merges when the asterisk PR does.

@github-actions github-actions bot added cherry-pick-checks-failed Cherry-Pick checks failed and removed cherry-pick-testing-in-progress Cherry-Pick tests in progress labels Jan 7, 2026
@github-actions github-actions bot added cherry-pick-testing-in-progress Cherry-Pick tests in progress and removed cherry-pick-test cherry-pick-checks-failed Cherry-Pick checks failed labels Jan 7, 2026
@asterisk asterisk deleted a comment from github-actions bot Jan 7, 2026
@github-actions github-actions bot added cherry-pick-checks-passed Cherry-Pick checks passed and removed cherry-pick-testing-in-progress Cherry-Pick tests in progress labels Jan 7, 2026
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Workflow PRCPCheck completed successfully

@github-actions github-actions bot merged commit 49c4941 into asterisk:master Jan 7, 2026
45 of 48 checks passed
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Successfully merged to branch master and cherry-picked to ["20","22","23"]

@maximilianfridrich maximilianfridrich deleted the pjsip_message_redirect branch January 8, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcolp jcolp jcolp approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

cherry-pick-checks-passed Cherry-Pick checks passed pr-submit-tests-passed pre-merge-checks-passed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maximilianfridrich @gtjoseph @jcolp