Fix npm test on Node 24: use explicit glob instead of directory path - #12
Merged
Merged
Conversation
node --test treats positional args as glob patterns on Node 24, so "scripts/lib/" matched the directory itself and failed with MODULE_NOT_FOUND. Node 26 (used locally) accepts directories, which is why it passed locally but failed in CI. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MODULE_NOT_FOUNDforscripts/lib.node --testtreats its argument as a glob pattern, soscripts/lib/matched the directory itself and was loaded as a test file. Node 26 (local) accepts directories, which is why it passed locally."test": "node --test \"scripts/lib/*.test.mjs\"". Quoted so Node expands the glob identically on Windows and Linux.Verification
npm run cilocally: 13/13 tests pass, check, readme:check, and build succeed.🤖 Generated with Claude Code