Repository navigation
docs: name pull request 4 as the subject to land - #11
Closed
juliantellez wants to merge 1 commit into
Closed
juliantellez wants to merge 1 commit into
juliantellez wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What. Records pull request 4 as the one to land, with its head branch, its head commit, and the name of the check that fails on it.
Why. The next step is a new session and it reads nothing from this one, so the pick has to be written down. Pull request 4 is the oldest of the seven open pull requests, it is not a draft, it conflicts with nothing, and no other pull request is based on its branch.
Two things a reader needs.
gh pr checks 4prints two passing checks and exits 0. The failing check,plan and apply, is on the commit but not in that summary, because the deploy workflow does not start on a pull request. Readcommits/84d9fe37/check-runsinstead. And the failure is inherited frommain: every deploy run in this repository failed on the same step.The file lands at
docs/the-subject-to-land.md, so it conflicts with none of the six other open pull requests. Four of them already add a file calledsubject.md.