docs: the subject to land is pull request 4, red on plan and apply - #15
Closed
juliantellez wants to merge 1 commit into
Closed
juliantellez wants to merge 1 commit into
juliantellez wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What. Adds
docs/the-subject-is-pull-request-4.md. It names pull request 4 as the one to land, and it records the state that decided the pick.Why. Eleven pull requests are open. Ten are clean and green. Pull request 4 is the oldest and it is the only one with a check that is not passing. That check is
plan and apply, andgh pr checks 4does not print it, because thedeployworkflow does not start on a pull request. An absent check reads the same as a passing one, so the report says how to read the check runs on the head commit instead.The file also records the exclusions: no draft, no pull request based on another pull request's head branch, and no conflict, tested with
git merge-treeas well as with the interface.The path is unique, so this conflicts with none of the other ten.
Subject: #4