Repository navigation
docs: name pull request 4 as the subject to land - #17
Closed
juliantellez wants to merge 1 commit into
Closed
juliantellez wants to merge 1 commit into
juliantellez wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What. Adds
docs/subject-4-the-oldest-with-a-red-check.md. The file names the pull request toland, with its number, title, head branch, head commit, conflict state and the name of every check
that is not passing.
Why. The next step runs in a new session. It reads nothing from this one, so the pick has to be
written down.
The subject is pull request 4, #4. It is the oldest
of the thirteen open pull requests. It is the only one with a check that is not passing. That check
is
plan and apply, and its conclusion is failure.gh pr checks 4does not print that check. It prints two passes and exits 0. Thedeployworkflowstarts on a push to
mainand on a manual start, never on a pull request, so GitHub keeps the runout of the pull request summary. Read the check runs on the head commit instead. An absent check
looks the same as a passing check.
I checked the exclusions. No open pull request is a draft. Every base branch is
main, so no headbranch carries a child. I did not trust the
MERGEABLElabel for the conflict test: I rangit merge-tree --write-tree origin/main <head>on all thirteen heads, and each one exits 0 with noconflict line.
Gates on this branch, each run as its own command:
npm ci,npm run typecheck,npm run lint,npm run test:count(75 total, 75 passed, 0 failed),npm run build,npm run verify:package(
GET /answered 200 with 4697 bytes),terraform fmt -check -recursive,terraform init -backend=falseandterraform validate. Every one exits 0.