Repository navigation
docs: say what landing pull request 4 found - #8
Closed
juliantellez wants to merge 3 commits into
Closed
juliantellez wants to merge 3 commits into
juliantellez wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What. Adds
land.md. It records the attempt to land #4: what the merge did, which gates passed, and why the one failing check stays red.Why. Pull request 4 already carries
origin/main, so the merge made no commit and there was no conflict. Itscodeandinfrastructurechecks pass. Its third check,plan and apply, fails, and it fails for a cause the pull request does not introduce and cannot fix.The
deployworkflow does not run on a pull request, so that check is invisible in the pull request summary. I read it on the commit and I read its log.The deploy applies. The function url answers 200. The front page answers 200. The last step asks the deployed page for a transcript and gets 502 eight times over four minutes. The function's own log in eu-west-1 names the cause:
bot_check, playabilityLOGIN_REQUIRED, "Sign in to confirm you are not a bot". The same code from a machine the platform does not refuse reads 560 caption segments. The block is on the address the function calls from.The run on
mainat3b5f6ccfails on the same step, answering 404 eight times. That 404 is the defect pull request 4 fixes. After it, the page answers 502 and names the refusal.I changed no code. Making the step pass means weakening it, and the product would still be broken. Getting past the refusal needs a different address to call from, and every way to get one bills while nobody visits. The project context refuses those by name, so this is a decision for a person.