Throw current exception instead of recreate them

[ElGigi]

Hello,

In case of some exceptions, order of parameters is not the same as Exception.

Error: Wrong parameters for PDOException([string $message [, long $code [, Throwable $previous = NULL]]])

So throw the current exception instead of recreate them is preferable.

Ronan

[ElGigi]

Any news ?

[froschdesign]

@ElGigi
Have you check the unit tests, because the associated test failed with your changes:

Atlas.Orm/tests/Transaction/AutoTransactTest.php

Lines 30 to 34 in d3d6bdb

	$previous = $e->getPrevious();
	$this->assertSame(
	$previous->getMessage(),
	"Primary key value for 'id' changed"
	);

@pmjones
Is there a reason why Travis was removed in db21a14?

[ElGigi]

@froschdesign Thanks, test fixed ;)

[ElGigi]

Any news?

I always have the error:
Error: Wrong parameters for PDOException([string $message [, long $code [, Throwable $previous = NULL]]]) in ...\vendor\atlas\orm\src\Transaction\AutoTransact.php:37

Thanks.

[ElGigi]

Any news? Thanks.

[harikt]

I think probably casting to int will help here.

public __construct ([ string $message = "" [, int $code = 0 [, Throwable $previous = NULL ]]] )

taken from https://www.php.net/manual/en/exception.construct.php .

So the order of exception seems not changing. Also if this code is removed, that may affect other parts for this can become a BC break for people who rely on multiple exception. ( Just a thought )