This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Open
Conversation
Contributor
|
@smashwilson What do you think here? |
Arcanemagus
approved these changes
Apr 29, 2019
Arcanemagus
left a comment
Arcanemagus
left a comment
There was a problem hiding this comment.
The changes this PR itself is making are valid, the CI failures appear to be unrelated to this change so I'll leave merging to @smashwilson if they want to look into those first.
Contributor
|
👍 Yeah, CI is failing because clang-format has breaking changes 🙃 This is an easy merge the next time I have cycles to spend over here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
'sudo' seems to be unavailable.
Remove sudo settings from .travis.yml
https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration
Alternate Designs
Benefits
Possible Drawbacks
Applicable Issues