Open
Conversation
Signed-off-by: dumsum <dumsum@pm.me>
Signed-off-by: dumsum <dumsum@pm.me>
Signed-off-by: dumsum <dumsum@pm.me>
Signed-off-by: dumsum <dumsum@pm.me>
dumsum
force-pushed
the
simon/nvme_arm_riscv
branch
from
11d5437 to
16ae80a
Compare
Signed-off-by: dumsum <dumsum@pm.me>
dumsum
force-pushed
the
simon/nvme_arm_riscv
branch
from
16ae80a to
e12a826
Compare
midnightveil
approved these changes
Apr 7, 2026
Contributor
midnightveil
left a comment
midnightveil
left a comment
There was a problem hiding this comment.
I think there's some bigger issues regarding how our build systems handles variants of the same board, but in lieu of more major restructurings this seems fine.
Would it be possible to make these work in our CI autotests, or is that hard?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly some build time configuration of addresses and meta.py hacking; needed to reorder things a bit.