-
Notifications
You must be signed in to change notification settings - Fork 353
chore: reduce chance of flakiness on the migrate integration test #2674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds retries and increases the wait timeout for the migration call
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2674 +/- ##
==========================================
- Coverage 79.46% 79.45% -0.00%
==========================================
Files 455 455
Lines 47161 47161
==========================================
- Hits 37470 37467 -3
+ Misses 6945 6944 -1
- Partials 2746 2750 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
| require.NoError(t, err) | ||
|
|
||
| waitCtx, cancel := context.WithTimeout(context.Background(), 5*time.Second) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we even have a timeout here..? i say let the thing take as long as it wants: remove the retry stuff and the waitCtx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want the test to hang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it won't hang, that's what go test -timeout XXX is for: https://github.com/authzed/actions/blob/main/go-test/action.yaml#L11
ugh we don't use that action for these. can you add -timeout 20m to
Lines 42 to 51 in 03a31da
| func testWithArgs(ctx context.Context, args ...string) ([]string, error) { | |
| testArgs := append([]string{ | |
| "test", | |
| "-failfast", | |
| "-count=1", | |
| "-race", | |
| }, args...) | |
| return testArgs, nil | |
| } |
Also FYI, github actions have a default timeout of 360 minutes per step.
|
Closing in favor of #2696 |
Adds retries and increases the wait timeout for the migration call