Repository navigation
Remove CommonJS support - #3437
Conversation
|
Ready |
Loading is always done using import(), so we'll never get a function directly.
… unused module type setup
In object form, this needs to be specified as cjs: true.
|
@sindresorhus looks good! I've tried to summarize the breaking changes in the PR description. Unfortunately this does impact the I've pushed a few further simplifications. I did add back support for configuring a I wonder if, instead of mandating |
I would just remove support for object form. |
|
Your changes look good. |
|
avajs/typescript#63 is green, but I need to do a bunch of config to make it publish, so that's for another evening. |
novemberborn
left a comment
novemberborn
left a comment
There was a problem hiding this comment.
Just waiting for CI to pass and then this can be merged.
0cbabae to
18cd65c
Compare
| @@ -68,18 +68,18 @@ Provide the `typescript` option (and install [`@ava/typescript`](https://github. | |||
|
|
|||
| @@ -42,7 +42,7 @@ Arguments passed to the CLI will always take precedence over the CLI options con | |||
|
|
|||
| ## Options | |||
3 participants
Fixes #3349
Breaking changes:
ava.config.cjsfilesimport()to load test files and extra modules through therequireconfiguration.cjsextension in the defaults (so will not findtest.cjsfiles)commonjsvalue in theextensionsconfigurationava-8to reflect these changes (requires new@ava/typescript)