Sigv4a followup #32
Sigv4a followup #32
Conversation
onno-vos-dev
left a comment
onno-vos-dev
left a comment
There was a problem hiding this comment.
Not leaving comments for all places but the unexported types are present in a couple
| { method :: binary() | ||
| , url :: binary() | ||
| , headers :: headers() | ||
| , headers :: aws_sigv4_internal:headers() |
There was a problem hiding this comment.
Type is not exported (unless I'm blind on my phone)
There was a problem hiding this comment.
They are in the -export_type block in aws_sigv4_internal.erl.
| [ Header | ||
| , ":" | ||
| , lists:join(",", lists:map(fun aws_sigv4_utils:trimspace/1, lists:reverse(Values))) | ||
| , lists:join(",", lists:map(fun string:trim/1, lists:reverse(Values))) |
There was a problem hiding this comment.
string:trim/1 nicely enough does not work on binaries so I think the original needs to remain here unless they're lists and I'm overlooking something.
There was a problem hiding this comment.
Docs say it should work, and OTP-25 agrees:
1> string:trim(<<" foo ">>).
<<"foo">>
| binary(), binary(), headers(), binary(), map()) | ||
| -> {ok, headers()} | {error, any()}. | ||
| binary(), binary(), aws_sigv4_internal:headers(), binary(), map()) | ||
| -> {ok, aws_sigv4_internal:headers()} | {error, any()}. |
There was a problem hiding this comment.
Unexported type (same as line above)
|
|
||
| %% sigv4a.SignString | ||
| -spec sign_string(binary()) -> sign_string(). | ||
| -spec sign_string(binary()) -> aws_sigv4_internal:sign_string(). |
|
Makes me realize I really should add a dialyzer step to the pipeline |
|
Nice! 👍🚢 Happy days 👍 |
FWIW I compile this repo with |
Yeah I'll fix it soon 👍 |
|
I'll tag this |
That works! Release train should take care of everything 👍 |
I don't have permission to push tags, and that also prevents me running the GH "make release" thing. Not a huge problem, I'll just point |
@mikpe Try again 👍 |
It worked now, thanks. |
2 participants
Cleanups requested by Onno in the initial PR. No change in behaviour.