Skip to content

test: configure git in browser tests workflow#976

Merged
avi-alpert merged 1 commit intoaws:mainfrom
avi-alpert:aalpert/fix-browser-e2e
Apr 27, 2026
Merged

test: configure git in browser tests workflow#976
avi-alpert merged 1 commit intoaws:mainfrom
avi-alpert:aalpert/fix-browser-e2e

Conversation

@avi-alpert
Copy link
Copy Markdown
Contributor

@avi-alpert avi-alpert commented Apr 27, 2026

Description

Fix workflow failure: https://github.com/aws/agentcore-cli/actions/runs/25002886488/job/73219242607

Add the missing Configure git step to the browser-tests CI job. agentcore create runs git init + git commit internally, which fails on GitHub Actions runners that don't have a git identity configured.

This was missed when splitting browser tests into their own job in #975 — the e2e job had this step but it wasn't carried over.

Related Issue

Follow-up to #975

Documentation PR

N/A

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

  • Verified the step is identical to the one in the e2e job

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@avi-alpert avi-alpert requested a review from a team April 27, 2026 15:22
@github-actions github-actions Bot added size/xs PR size: XS agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Apr 27, 2026
@avi-alpert avi-alpert merged commit 17b5727 into aws:main Apr 27, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants