fix: update aurora connection tracker and fix writer host comparison #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenc-bq
force-pushed
the
fix/aurora-connection-tracker
branch
3 times, most recently
from
1a01f31 to
fcdd465
Compare
karenc-bq
force-pushed
the
fix/aurora-connection-tracker
branch
from
fcdd465 to
1e05ee3
Compare
Comment on lines
+56
to
+59
| def _start_prune_thread(cls): | ||
| if cls._prune_thread is None or not cls._prune_thread.is_alive(): | ||
| cls._prune_thread = Thread(daemon=True, target=cls._prune_connections_loop) | ||
| cls._prune_thread.start() |
Contributor
There was a problem hiding this comment.
We need a lock for this, it's more rare, but we could have 2 initial connections both calling this and starting 2 threads.
| _opened_connections: ClassVar[Dict[str, WeakSet]] = {} | ||
| _rds_utils: ClassVar[RdsUtils] = RdsUtils() | ||
| _prune_thread: ClassVar[Optional[Thread]] = None | ||
| _shutdown_event: ClassVar[threading.Event] = threading.Event() |
Contributor
There was a problem hiding this comment.
This is never set so thread is never shut down. Maybe we should have this in the release_resources method in the wrapper.py and change this in a release_resources() method or something like that).
| while not cls._shutdown_event.is_set(): | ||
| try: | ||
| cls._prune_connections() | ||
| time.sleep(cls._default_sleep_time) |
Contributor
There was a problem hiding this comment.
We should probably do a wait on the event instead of a sleep:
e.g.
if cls._shutdown_event.wait(timeout=cls._default_sleep_time):
break
It's a daemon thread so it won't cause the program to hang, but just incase, this will help with making it exit gracefully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aurora Connection Tracker is outdated.
This PR ports over some improvements and fixes for the plugin.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.