Remove elastictranscoder examples following the deprecation of the service #9946
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #9946 +/- ##
===========================================
- Coverage 93.40% 93.35% -0.06%
===========================================
Files 211 209 -2
Lines 17012 16950 -62
===========================================
- Hits 15890 15823 -67
- Misses 1122 1127 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jonathan343
left a comment
jonathan343
left a comment
There was a problem hiding this comment.
There are still references to elastictranscoder in argrename.py, conf.py, test_cli.py, and test_waiters.py. Once we get those cleaned up, this should be good.
jonathan343
dismissed
their stale review
Revoking for now until we can confirm all failed tests are expected and succeed against the modified version of botocore in boto/botocore#3614
| self.parsed_response = {'Table': {'TableStatus': 'ACTIVE'}} | ||
| self.assert_params_for_cmd(cmdline, result) | ||
|
|
||
| def test_elastictranscoder_jobs_complete(self): |
There was a problem hiding this comment.
We don't need to remove this, I think the test is misnamed. See renaming I did for v2:
|
The tests are failing because the argument rename was removed: These will continue to fail until CLI v1 can use |
4 participants
Issue #, if available:
Description of changes:
After the merge of boto/botocore#3614, we can remove the examples here as the client will no longer be functional.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.