Skip to content

fix(app delete): reject positional app names#7396

Open
KirtiRamchandani wants to merge 1 commit into
aws:mainlinefrom
KirtiRamchandani:fix/app-delete-reject-positional-name
Open

fix(app delete): reject positional app names#7396
KirtiRamchandani wants to merge 1 commit into
aws:mainlinefrom
KirtiRamchandani:fix/app-delete-reject-positional-name

Conversation

@KirtiRamchandani
Copy link
Copy Markdown

Rejects positional application names for copilot app delete so copilot app delete example-app fails before it can delete the default workspace application. The command examples and command reference now show --name for deleting a specific application.

Fixes #6048

Tests run:

  • go test ./internal/pkg/cli -run TestAppDeleteCommandRejectsPositionalAppName
  • go test ./internal/pkg/cli -run 'Test(AppDeleteCommandRejectsPositionalAppName|DeleteAppOpts_(Ask|Execute))'
  • git diff --check

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@KirtiRamchandani
Copy link
Copy Markdown
Author

The failing Summary / Mergify Merge Queue checks here are from the repository-wide Mergify config, not this PR's code. The check-run output reports actions.queue.method and actions.queue.commit_message_template as invalid extra inputs.

Opened #7398 to move the squash merge strategy and commit-message settings onto queue_rules, which should address the shared Mergify validation failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accidental deletion caused by undocumented --name default in app delete command

1 participant