Alternate approach to solve #8482 based on ideas from @moko-poi in PR #8547

[youwalther65]

Alternate approach to solve #8482 based on ideas from @moko-poi in PR #8547

Fixes #8482

Description
Adds FleetID to Karpenter controller logs in case of InsufficientInstanceCapacity error in EC2 CreateFleet API call.

Moved logging out of pkg/cache/unavailableofferings.go func MarkUnavailable.

After offline discussion with @DerekFrank I moved logging back to pkg/cache/unavailableofferings.go func MarkUnavailable, but now keep log item order backward compatible using approach here.

How was this change tested?

Does this change impact docs?

• Yes, PR includes docs updates
• Yes, issue opened: #
• No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[netlify]

✅ Deploy Preview for karpenter-docs-prod ready!

Name	Link
🔨 Latest commit	8908c3a
🔍 Latest deploy log	https://app.netlify.com/projects/karpenter-docs-prod/deploys/69202484a1001900089f33f3
😎 Deploy Preview	https://deploy-preview-8684--karpenter-docs-prod.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[moko-poi]

Thanks @youwalther65 and @DerekFrank for following up on this!

I'm totally fine with continuing this work in #8684 — it keeps the intent of #8547 while making the log order deterministic and preserving backward compatibility.
The main goal from my side was always to surface the FleetID for CloudTrail correlation, without adding noise (like empty fleet-id fields) or changing the existing log structure.

Happy to close #8547 once this PR becomes the final implementation.

[github-actions]

Preview deployment ready!

Preview URL: https://pr-8684.d18coufmbnnaag.amplifyapp.com

Built from commit 8908c3a99bcafd59be42637c7f602fe6456f4b0d

[coveralls]

Pull Request Test Coverage Report for Build 19564760545

Details

• 23 of 27 (85.19%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.001%) to 67.541%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/cache/unavailableofferings.go	10	12	83.33%
pkg/providers/instance/instance.go	9	11	81.82%

Totals
Change from base Build 19552925199:	0.001%
Covered Lines:	7824
Relevant Lines:	11584

---

💛 - Coveralls

[DerekFrank]

LGTM! Thanks for picking this up