Properly calculate hash of EC2NodeClass for ISO regions #8699
+130
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
DerekFrank
reviewed
Nov 12, 2025
Contributor
DerekFrank
left a comment
DerekFrank
left a comment
There was a problem hiding this comment.
Just some small comments, overall looks good!
| ) | ||
|
|
||
| // HTTPProtocolUnsupportedRegions contains regions that don't support HTTPProtocolIPv6 | ||
| var HTTPProtocolUnsupportedRegions = []string{ |
Contributor
There was a problem hiding this comment.
We can keep this a Set and just refer to it in the amiprovider instead of turning the slice into a set
| SlicesAsSets: true, | ||
| IgnoreZeroValue: true, | ||
| ZeroNil: true, | ||
| }))) |
Contributor
There was a problem hiding this comment.
Do we need to keep the .Hash() function around?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7081
Description
In ISO regions the httpProtocolIPv6 feature is not supported. The current code correctly handles this by setting HTTPProtocolIPv6 to nil in unsupported regions. However, the EC2NodeClass spec still contains the default value for HTTPProtocolIPv6 (which is "disabled"). When the hash is calculated, it includes the entire Spec which has HTTPProtocolIPv6: "disabled". But when the launch template is created, HTTPProtocolIPv6 is set to nil (omitted). This creates a mismatch between what's in the NodeClass hash and what's actually deployed. This code properly sets the hash value for the NodeClass.
How was this change tested?
Unit tests
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.