I/Q: Implement AutoSave option and make various smaller improvements#237
Open
hanno-becker wants to merge 4 commits into
Open
I/Q: Implement AutoSave option and make various smaller improvements#237hanno-becker wants to merge 4 commits into
hanno-becker wants to merge 4 commits into
Conversation
createFileWithContent wrote Symbol.decode'd content verbatim, leaving raw Unicode glyphs on disk that isabelle build's symbol-strict loader rejects. Re-encode to named form, matching the jEdit buffer.save path. Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
Persist write_file edits to disk immediately so the jEdit buffer and the file system stay in sync. Shared IQAutoSave state, on by default, toggled via the set_auto_save MCP tool or the dockable checkbox, kept in sync via a listener. Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
Handler validation failures now return MCP results with isError:true rather than JSON-RPC errors (since c1c3967). Assert the new shape via an assertToolError helper; protocol- and auth-level errors keep the old check. Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
The README tool-list check only scanned numbered entries, so the bulleted authenticate entry showed as a spurious mismatch. Accept both styles and stop before the I/R REPL subsection, which is excluded server-side too. Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a default-on configuration option for auto-saving files upon edit through I/Q. This is enabled by default because agents can't seem to work out that switching between file-system tools and I/Q otherwise leads to conflicts.
The PR also fixes a unicode issue whereby initial file contents written by
openFilewould not be ascii-encoded, making the Isabelle build fail.Finally, some smaller fixes to pre-existing test issues.