Allow script to continue deleting other resources #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakuna-matatah
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow script to continue deleting other resources even if delete cluster failed.
Also add to wait for cluster deletion.
Issue #, if available:
Cluster teardown in tekton pipeline exit early due to cluster not found and hence never reached to delete VPC and other resources. Cluster delete step should not exit early or block the entire teardown workflow.
Description of changes:
Add set +e to allow the script to continue execution even if a command fails.
Add wait command to wait for cluster deletion in case VPC stack deletion fail due to resources like subnet still attached to cluster.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.