This repository was archived by the owner on Nov 20, 2025. It is now read-only.
Add support for detecting the number of available Neuron cores#1002
Open
aws-taylor wants to merge 4 commits intoawslabs:masterfrom
Open
Add support for detecting the number of available Neuron cores#1002aws-taylor wants to merge 4 commits intoawslabs:masterfrom
aws-taylor wants to merge 4 commits intoawslabs:masterfrom
Conversation
maaquib
approved these changes
Aug 24, 2022
lxning
approved these changes
Aug 24, 2022
Author
|
I believe the following block in `getDefaultWorkers()` will cause it to have the desired effect:
```
if (workers == 0) {
workers = getNumberOfNeuronCores();
}
```
From: lxning ***@***.***>
Reply-To: awslabs/multi-model-server ***@***.***>
Date: Wednesday, August 24, 2022 at 12:15 PM
To: awslabs/multi-model-server ***@***.***>
Cc: "Goodhart, Taylor" ***@***.***>, Mention ***@***.***>
Subject: Re: [awslabs/multi-model-server] Add support for detecting the number of available Neuron cores (PR #1002)
@aws-taylor<https://github.com/aws-taylor> This PR make MMS get the number of Neuron Cores, but don't see it is used in MMS internally. Will you have another PR to address it?
—
Reply to this email directly, view it on GitHub<#1002 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANYNIBQKSB272JDEDFIIR7DV2ZYBRANCNFSM57MQNFLA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before or while filing an issue please feel free to join our
slack channel to get in touch with development team, ask questions, find out what's cooking and more!
Issue #, if available:
Description of changes:
Similar to GPUs, when running on AWS Inf1 instance types, automatically detect the number of available Neuron cores and set the number of workers accordingly.
Testing done:
Ran tests on inf1, logs correctly show 16 neuron cores on an inf1.6xlarge.
To run CI tests on your changes refer README.md
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.