This repository was archived by the owner on Nov 20, 2025. It is now read-only.
Fix misnamed model_url query parameter in openapi docs#1008
Open
mulhod wants to merge 2 commits intoawslabs:masterfrom
Open
Fix misnamed model_url query parameter in openapi docs#1008mulhod wants to merge 2 commits intoawslabs:masterfrom
mulhod wants to merge 2 commits intoawslabs:masterfrom
Conversation
davidthomas426
approved these changes
Jun 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: no issue
Description of changes:
The openapi documentation claims that there is a
model_urlquery parameter for the/models/POST endpoint. However, it appears the parameter name is actually justurl.Observe:
If
model_urlis changed tourl, this works, however:Furthermore, this seems to be how it's even used in tests, e.g., here.
Testing done:
I can set up a local environment to test this, but it's just a change to documentation, basically.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.