Skip to content

refactor(commands): merge fs/impor/fab_fs_import_item.py into fab_fs_import.py#68

Open
Copilot wants to merge 4 commits intomainfrom
copilot/fix-import-paths
Open

refactor(commands): merge fs/impor/fab_fs_import_item.py into fab_fs_import.py#68
Copilot wants to merge 4 commits intomainfrom
copilot/fix-import-paths

Conversation

Copy link

Copilot AI commented Feb 24, 2026

📥 Pull Request

✨ Description of new changes

The src/fabric_cli/commands/fs/impor/ directory was misspelled and contained a single file (fab_fs_import_item.py). Rather than renaming the directory to import (which is a Python keyword and would require importlib workarounds), the content of fab_fs_import_item.py has been merged directly into fab_fs_import.py and the subdirectory removed entirely.

  • Summary: Eliminated the misspelled fs/impor/ subdirectory by merging fab_fs_import_item.py into fab_fs_import.py. The import_single_item function and its helpers now live directly in fab_fs_import.py, keeping the code simple with no importlib usage.
  • Context: The impor/ directory name was a typo (should have been import), but since import is a Python keyword, a subdirectory with that name would require non-standard import mechanisms. Merging the files avoids this issue entirely and is consistent with keeping thin command files.
  • Dependencies: None. No test changes needed — tests reference through the parser/command layer, not the subdirectory directly.

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: ayeshurun <98805507+ayeshurun@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix import paths in fabric_cli commands fix(commands): rename fs/impor directory to fs/import Feb 24, 2026
Copilot AI requested a review from ayeshurun February 24, 2026 13:04
Co-authored-by: ayeshurun <98805507+ayeshurun@users.noreply.github.com>
…subdirectory

Co-authored-by: ayeshurun <98805507+ayeshurun@users.noreply.github.com>
Copilot AI changed the title fix(commands): rename fs/impor directory to fs/import refactor(commands): merge fs/impor/fab_fs_import_item.py into fab_fs_import.py Feb 26, 2026
@ayeshurun ayeshurun marked this pull request as ready for review February 26, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants