Skip to content

BUG: Fix metric bug in Utilities #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dguijo merged 2 commits into from
Jul 27, 2025
Merged

BUG: Fix metric bug in Utilities #33

dguijo merged 2 commits into from
Jul 27, 2025

Conversation

@angelsevillamol
Copy link
Collaborator

@angelsevillamol angelsevillamol commented Jul 26, 2025

What does this implement/fix? Explain your changes

This PR fixes two issues in the Utilities class:

  • Corrects a bug where all metrics were computed using cv_metric instead of the user-provided list in metrics.
  • Fixes the incorrect import of the metrics module that caused execution errors.

@angelsevillamol angelsevillamol requested a review from dguijo July 26, 2025 16:02
@angelsevillamol angelsevillamol added bug Something isn't working module:utilities labels Jul 26, 2025
dguijo
dguijo approved these changes Jul 27, 2025
View reviewed changes
Copy link
Member

@dguijo dguijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@dguijo dguijo merged commit cdf41b9 into main Jul 27, 2025
9 checks passed
@angelsevillamol angelsevillamol deleted the bug-utilities-metrics branch September 1, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dguijo dguijo dguijo approved these changes

Assignees

No one assigned

Labels

bug Something isn't working module:utilities

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@angelsevillamol @dguijo