Refactor/adapt to yosemite by zenangst · Pull Request #45 · b4winckler/macvim

zenangst · 2014-09-11T17:07:39Z

I've added a new tab style that conforms with the new look in Yosemite.

I was wondering what you guys think of it so far?

On my todo list so far:

Change the way the close button looks and behaves
Change tab bar height
Change the "New Tab" icon on the right side
Change font color depending on tab state - zenangst@67fb6e6

b4winckler#44

Makes more sense to truncate on head because of Cocoa name-spacing prefixes

Making it feel more like Xcode than Terminal (I don’t know how I feel about this)

This reverts commit f1da0db.

Match Xcode 6

Remove C preprocessor

lucascaton · 2014-10-18T02:36:57Z

That looks amazing dude, nice job! Congrats!

tomekw · 2014-10-18T11:49:40Z

No idea where to raise this issue but entering the fullscreen doesn't work on Yosemite (/cc @b4winckler)

Top left corner:

http://cl.ly/image/292113231m3L

Bottom left corner:

http://cl.ly/image/120P0M1R122Q

maxcountryman · 2014-10-20T20:13:57Z

@tomekw I'm having the same problem.

benoitc · 2014-10-27T21:32:12Z

@tomekw @maxcountryman I applied this patch in my repo [1] from the google code tracker [2] as a workaround. It seems to fix most case even if resizing is not that good.

[1] benoitc@9f77ac3
[2] https://code.google.com/p/macvim/issues/detail?id=514&start=100

eric-wood · 2014-10-29T14:37:55Z

This is fantastic, really looking forward to this making it upstream! 👍 👍 👍

RobertsChou · 2014-10-29T14:41:06Z

Thank u , good job

krid78 · 2014-10-30T10:48:30Z

I compiled and testes the version (zenangst/macvim). The issue with missing top lines when only one tab is open at full screen mode is still there.

regards

jordwalke · 2014-11-09T22:28:39Z

👍

vestimir · 2014-11-15T08:47:10Z

Looks great. 👍

offtopic: @krid78 @benoitc @tomekw About the blank lines there's a fix in progress here - #48

mikekreeki · 2014-12-15T11:45:02Z

👍

eirnym · 2015-01-18T16:40:57Z

👍

luishdez · 2015-01-27T08:14:59Z

Awesome work!

I will add these extras to the tasks

[ ] Use hover native scrolls ( invisible ones )
[ ] Dark mode for yosemite

UrsaDK · 2015-01-28T10:14:15Z

👍

zenangst · 2015-01-29T07:59:39Z

Hey folks, thanks for your support and enthusiasm. Kinda swamped at work right now but this is on my todo-list... and I would love to finish pully.

vestimir · 2015-01-30T22:43:05Z

@zenangst what do you mean by

Change the way the close button looks and behaves

PS: Great job so far! 🎯

christianparpart · 2015-03-08T09:54:15Z

hey guys. is there an update on this so far? or got it suspended?

simono · 2015-03-13T14:16:41Z

I don't think this repository is active anymore. #44 (comment)

jean-io · 2015-10-06T06:23:03Z

Hi,

This repo is no longer active, however this one is: https://github.com/macvim-dev/macvim

Any chance you could update it?

mikekreeki · 2015-10-06T06:58:48Z

Would be very cool 👍

jordwalke · 2015-12-28T00:39:17Z

This would be really awesome to have. Any chance you could submit the pull request to the new official repo at https://github.com/macvim-dev/macvim ? That repo is fairly active now and I'm hoping there will be some people excited to take a closer look at your PR.

splhack · 2015-12-28T06:41:01Z

I've revised this pull request in macvim-dev/macvim#193, now you can improve and send pull requests for feature/yosemite-tab-style branch of https://github.com/macvim-dev/macvim.

Yosemite Tab Style based of b4winckler/macvim#45

Binary targets OS X 10.8(Mountain Lion), 10.9(Mavericks), 10.10(Yosemite), and 10.11(El Capitan) - Vim patch 7.4.1090 - Fix renderer defaults settings, Core Text Renderer should be the default - Yosemite style Tab bar based on b4winckler/macvim#45 Script interfaces have compatibility with these versions - Lua 5.2 - Perl 5.16 - Python2 2.7 - Python3 3.5 - Ruby 2.0

zenangst added 30 commits August 25, 2014 18:13

Add @jasonlong's proposed icon

f1da0db

b4winckler#44

Add Yosemite tab style

4e1c7f6

Copy PSMMetalTabStyle implementation & interface

97828f1

Enable Yosemite tab style on OS X 10.10

8441d93

Tweak tab bar appearance

1976683

More GUI tweaks

bacf495

Fix offset on inactive tabs

6fe3b1d

Remove log statement

64d770d

Remove whitespace

2408320

Change tab size on Yosemite

1767280

Remove +1 width on inactive tabs

74af43f

Fix handling of window states when drawing tabs

1ea814f

Use Yosemite tab style for fullscreen on 10.10

172669f

Change truncating to truncate on head instead of tail

d28d4ed

Makes more sense to truncate on head because of Cocoa name-spacing prefixes

Fix syntax error

ac5406f

Use screen width instead of hardcoded values in tab bar control

7d141a8

Remove text shadow on tabs

345607f

Simplify isKeyWindow declaration

052847a

Add tab bar separator

dbb6f24

Making it feel more like Xcode than Terminal (I don’t know how I feel about this)

Correct color on tabs

14fe0d2

Use Yosemite tab in fullscreen

847447c

Revert "Add @jasonlong's proposed icon"

678d37a

This reverts commit f1da0db.

Fix type error

41bd4ce

Set text color based on tab state and if window is key

67fb6e6

Make borderColor less intrusive

75dd91b

Add more contrast to the active tab

fa6fcfd

Remove rollover effect on tabs

013d781

Increase tab height

3c25dfd

Match Xcode 6

Rename object names to be more generic

5d72ef7

Refactor Yosemite tab style

54e7051

Remove C preprocessor

dhilipsiva mentioned this pull request Nov 24, 2014

Fix for the blank lines when entering fullscreen on Yosemite #48

Open

CarterLi mentioned this pull request Feb 5, 2015

MacVim-Yosemite-Python should link with system ruby too genoma/macvim#1

Closed

splhack added a commit to macvim-dev/macvim that referenced this pull request Dec 28, 2015

Yosemite Tab Style based of b4winckler/macvim#45

8c026f6

splhack added a commit to macvim-dev/macvim that referenced this pull request Jan 15, 2016

Yosemite Tab Style based of b4winckler/macvim#45

e268fb8

splhack added a commit to macvim-dev/macvim that referenced this pull request Jan 15, 2016

Merge pull request #193 from macvim-dev/feature/yosemite-tab-style

7cdd910

Yosemite Tab Style based of b4winckler/macvim#45

zenangst closed this Mar 15, 2017

Conversation

zenangst commented Sep 11, 2014

On my todo list so far:

Uh oh!

lucascaton commented Oct 18, 2014

Uh oh!

tomekw commented Oct 18, 2014

Uh oh!

maxcountryman commented Oct 20, 2014

Uh oh!

benoitc commented Oct 27, 2014

Uh oh!

eric-wood commented Oct 29, 2014

Uh oh!

RobertsChou commented Oct 29, 2014

Uh oh!

krid78 commented Oct 30, 2014

Uh oh!

jordwalke commented Nov 9, 2014

Uh oh!

vestimir commented Nov 15, 2014

Uh oh!

mikekreeki commented Dec 15, 2014

Uh oh!

eirnym commented Jan 18, 2015

Uh oh!

luishdez commented Jan 27, 2015

Uh oh!

UrsaDK commented Jan 28, 2015

Uh oh!

zenangst commented Jan 29, 2015

Uh oh!

vestimir commented Jan 30, 2015

Uh oh!

christianparpart commented Mar 8, 2015

Uh oh!

simono commented Mar 13, 2015

Uh oh!

jean-io commented Oct 6, 2015

Uh oh!

mikekreeki commented Oct 6, 2015

Uh oh!

jordwalke commented Dec 28, 2015

Uh oh!

splhack commented Dec 28, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants