Issue #22: Add support for CKEditor 5.#24
Issue #22: Add support for CKEditor 5.#24quicksketch wants to merge 3 commits intobackdrop-contrib:1.x-1.xfrom
Conversation
|
Many thanks @quicksketch - I've tested this PR and can confirm it works with CKEditor 5. |
|
@nattywebdev Thanks for testing! Do you mean that every time you insert a file, it creates a new paragraph tag? It should respect where the cursor is in the document, but I admit I did not test that level. It's entirely likely the the code I used will always wrap the newly inserted content in |
|
Revisiting this after the break and I find that the additional tags are now not inserted in my example. No idea what caused that issue before but my current example works just fine:
So thank you @quicksketch ! |
|
That's great, thank you @nattywebdev. However, now that backdrop/backdrop-issues#6770 has been released in 1.29.3, we can improve this code to use the new variable provided by CKEditor 5 core, so we don't have to track the instance ourselves. This can be merged as-is, but it could be improved by now removing the manual tracking. |
|
@quicksketch is this now dealt with by backdrop/backdrop-issues#6770 ? Or is something needed in the Insert module to access the relevant variable? I have no clue how to do that so will need help. |
Fixes #22. This also removes some support that is not applicable to Backdrop, including: