Skip to content

Conversation

@jNullj
Copy link
Member

@jNullj jNullj commented Aug 6, 2025

add examples to static badge docs with visual examples.
Add note about named color to avoid confusion around named colors.

part #11261

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

Warnings
⚠️ This PR modified service code for static-badge but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @jNullj!

Generated by 🚫 dangerJS against 7ffc07a

@jNullj jNullj added frontend The Docusaurus app serving the docs site documentation Developer and end-user documentation labels Aug 6, 2025
…or, and logo options

part of issue Better document configuration option badges#11261
@jNullj jNullj force-pushed the docs/static-badge-description-examples branch from 48d3b5b to 0009869 Compare August 9, 2025 14:06
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2025

🚀 Updated review app: https://pr-11263-badges-shields.fly.dev

@github-actions
Copy link
Contributor

🚀 Updated review app: https://pr-11263-badges-shields.fly.dev

@jNullj jNullj marked this pull request as ready for review August 23, 2025 16:42
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The available query parameters are already described in the table further down on the page, e.g.:
Screenshot 2025-09-01 at 17 55 55

I'm wondering whether we could keep the top text short and simple, and delete the Hex, rgb, rgba, hsl, hsla and css named colors may be used. sentence, but add the link to the available colors in the query parameter description. It would benefit all badges pages. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Developer and end-user documentation frontend The Docusaurus app serving the docs site

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants