Skip to content

Conversation

@PyvesB
Copy link
Member

@PyvesB PyvesB commented Oct 12, 2025

We've had several issues with dependency updates recently (see #11246, #11289, #11421, to name but a few). The fewer packages we depend on directly, the fewer headaches we risk having in the future.

One thing that struck me when going through our dependencies is that we have two separate dependencies to deal with query strings. We rely on qs to perform nested stringification needed for Wordpress badges, so I opted for attempting to port everything over from query-string to qs.

@PyvesB PyvesB added the core Server, BaseService, GitHub auth, Shared helpers label Oct 12, 2025
@github-actions
Copy link
Contributor

Messages
📖 ✨ Thanks for your contribution to Shields, @PyvesB!

Generated by 🚫 dangerJS against 25958be

Copy link
Member

@jNullj jNullj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's great, less braking changes and less supply chain attack vectors.
i hope this branch is not too far behind master so the package-lock is still valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Server, BaseService, GitHub auth, Shared helpers dependencies Related to dependency updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants