android/{Ble,Internal}Sensor: use SensorListItem.setState() #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Changes for next release are in stage. Please use this branch for as base for development. |
Commit 2148e79 ("Sensor Java to Kotlin") switched from using SensorListItem.setState() to assigning the `state` field directly. This however skips the isNextStateValid() check, unconditionally leaving the state `SCANNING`. This however broke BLE sensors: the next BleSensor.onCharacteristicRead() call would then call executeNextAndSetState() and setNextState(). With `isScanning==true`, setNextState() would invoke close(). The simple fix is to revert to using setState().
MaxKellermann
force-pushed
the
setstate
branch
from
4ef411c to
d1d52b7
Compare
Contributor
Author
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 2148e79 ("Sensor Java to Kotlin") switched from using SensorListItem.setState() to assigning the
statefield directly. This however skips the isNextStateValid() check, unconditionally leaving the stateSCANNING.This however broke BLE sensors: the next
BleSensor.onCharacteristicRead() call would then call executeNextAndSetState() and setNextState(). With
isScanning==true, setNextState() would invoke close().The simple fix is to revert to using setState().