Skip to content

Properly propagate "external" errors from erc4626 buffers/vaults #614

Description

@brunoguerios

Add liquidity to Base Aave GHO-USDC pool fails because Base GHO market is maxed out.

-> GHO market being maxed out would fail on wrapping GHO via the buffer

SDK should be able to properly propagate a meaningful errors to consumers (e.g. FE) so they can parse/handle it accordingly

Note: errors internal to Balancer are already being properly handled because we provide our ABIs to viem, which can then parse the error signature. Not sure how to handle "external" calls, like these made to erc4626 buffers/vaults.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions