apply ShellCheck suggestions #106

Flupp · 2021-03-07T13:49:20Z

I fixed some issues reported by ShellCheck. Some of them can be considered stylistic, however, some of them indicate actual problems.

This is a suggestion from ShellCheck.

… with e.g. 'if mycmd;', not indirectly with $?. This is a suggestion from ShellCheck.

Flupp added 7 commits March 7, 2021 14:43

fix SC2004: $/${} is unnecessary on arithmetic variables.

79531a7

This is a suggestion from ShellCheck.

fix SC2046: Quote this to prevent word splitting.

4bd0b47

This is a suggestion from ShellCheck.

fix SC2059: Don't use variables in the printf format string.

5d46334

This is a suggestion from ShellCheck.

fix SC2071: > is for string comparisons. Use -gt instead.

418ef6c

This is a suggestion from ShellCheck.

fix SC2086: Double quote to prevent globbing and word splitting.

76480c1

This is a suggestion from ShellCheck.

fix SC2140: Word is of the form "A"B"C".

915634a

This is a suggestion from ShellCheck.

fix SC2181: Check exit code directly

cb1041c

… with e.g. 'if mycmd;', not indirectly with $?. This is a suggestion from ShellCheck.

baodrate mentioned this pull request Feb 13, 2022

apply ShellCheck suggestions baodrate/snap-sync-forked#1

Merged

Provide feedback