Skip to content

MUI v5#12

Open
Zenoo wants to merge 39 commits into
bareynol:masterfrom
Zenoo:master
Open

MUI v5#12
Zenoo wants to merge 39 commits into
bareynol:masterfrom
Zenoo:master

Conversation

@Zenoo

@Zenoo Zenoo commented Apr 6, 2022

Copy link
Copy Markdown

This PR works on bringing MUI v5 to the repo.

I'm having some issues with the ts config for this repo:

I'm also fixing some Typescript issues as I see them.
I will update this PR when the upgrade is done.

@Zenoo

Zenoo commented Apr 6, 2022

Copy link
Copy Markdown
Author

The main work is done.
All there is left is removing every useStyles and replacing them with the sx prop.
I'm doing that right now.

Another error I can't seem to fix is in the website editor:

@Zenoo

Zenoo commented Apr 6, 2022

Copy link
Copy Markdown
Author

Alright, I fixed the error in the Monaco editor.
Only the usestyles left.

@Zenoo Zenoo marked this pull request as ready for review April 7, 2022 08:31
@Zenoo

Zenoo commented Apr 7, 2022

Copy link
Copy Markdown
Author

Everything should be done!

Fix tab color by swapping AppBar with Box
@shadoath

shadoath commented Sep 3, 2022

Copy link
Copy Markdown

This looks really sweet @bareynol any plans to merge this and give users the option to swap between v4 and v5?

@Zenoo

Zenoo commented Sep 3, 2022

Copy link
Copy Markdown
Author

@shadoath You can already do that by accessing the usual URL for v4, and the URL from my fork for v5

@shadoath

shadoath commented Sep 6, 2022

Copy link
Copy Markdown

@Zenoo thank you I have bookmarked your repo!

Looking at the number of changes I now realize that there is no way to have both the v4 and v5 MUI active at the same time.

@vfproductions

Copy link
Copy Markdown

I mde a fork and fixed a few minor things for v5, but im a github noob so dont know what to do with it. Its here https://github.com/vfproductions/mui-theme-creator

@Zenoo

Zenoo commented Sep 6, 2022

Copy link
Copy Markdown
Author

@vfproductions You can simply open a PR on my fork https://github.com/Zenoo/mui-theme-creator/pulls

@vfproductions

Copy link
Copy Markdown

@Zenoo yep nevermnind.. I already did that, and you completed it, and it's showing up here, so all is good. Just not used to seeing commits in ascending order. Weird

@vfproductions

Copy link
Copy Markdown

I did have one more small thing to PR, see Zenoo#4

@shadoath

shadoath commented Dec 2, 2024

Copy link
Copy Markdown

Checking in again? Is this something that will get merged?

@Zenoo

Zenoo commented Dec 2, 2024

Copy link
Copy Markdown
Author

@shadoath Since the original creator doesn't seem active anymore, you can find V5 on my fork https://github.com/Zenoo/mui-theme-creator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants