-
-
Notifications
You must be signed in to change notification settings - Fork 9
Docs: Restructure README with TypeScript focus and improved documentation structure #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Rate limit exceeded@bartholomej has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 16 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughComprehensive rewrite of Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #69 +/- ##
=======================================
Coverage 99.52% 99.52%
=======================================
Files 28 28
Lines 630 630
Branches 143 143
=======================================
Hits 627 627
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
🧹 Nitpick comments (1)
README.md (1)
395-398: Hyphenate compound adjectives.Lines 397 and 595 use "rate limiting" as a compound adjective before a noun. Per English grammar, these should be hyphenated as "rate-limiting".
Apply these diffs:
-397~ > ⚠️ **Rate Limiting Warning**: When fetching all pages, use appropriate delays... +397~ > ⚠️ **Rate-Limiting Warning**: When fetching all pages, use appropriate delays...-595~ - [ ] Server: Rate limiting helpers +595~ - [ ] Server: Rate-limiting helpers
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(6 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md
[uncategorized] ~397-~397: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...e: ['epizoda', 'série'] }); ``` >
(EN_COMPOUND_ADJECTIVE_INTERNAL)
[uncategorized] ~595-~595: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ... for improved performance - [ ] Server: Rate limiting helpers ## 🛠️ Development ### Prereq...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
[style] ~655-~655: Consider using a less common alternative to make your writing sound more unique and professional.
Context: ...ontributing Contributions are welcome! Please feel free to submit a Pull Request. ### How to Cont...
(FEEL_FREE_TO_STYLE_ME)
[style] ~664-~664: Consider using a more formal and expressive alternative to ‘amazing’.
Context: ...yarn test) 6. **Commit your changes** (git commit -m 'Add amazing feature') 7. **Push to the branch** (...
(AWESOME)
[style] ~701-~701: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ally can't. I have nowhere to store it. I don't even have a server database to st...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
🪛 markdownlint-cli2 (0.18.1)
README.md
11-11: Heading levels should only increment by one level at a time
Expected: h2; Actual: h3
(MD001, heading-increment)
13-13: Link fragments should be valid
(MD051, link-fragments)
75-75: Link fragments should be valid
(MD051, link-fragments)
513-513: Link fragments should be valid
(MD051, link-fragments)
629-629: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
| - [Docker Support](#-docker-support) | ||
| - [Development](#-development) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct Table of Contents link fragments.
Line 75 uses #-docker-support but should be #docker-support (remove the dash after hash). All emoji-prefixed headings auto-generate anchors by dropping the emoji and lowercasing, not by keeping a leading dash.
Apply this diff:
Committable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
75-75: Link fragments should be valid
(MD051, link-fragments)
🤖 Prompt for AI Agents
In README.md around lines 74 to 75, the Table of Contents links use fragment
anchors with an extra leading dash (e.g. "#-docker-support") that don't match
auto-generated emoji-prefixed heading anchors; update the TOC fragments by
removing the dash after the hash (e.g. change "#-docker-support" to
"#docker-support" and similarly for any other entries like "#-development" to
"#development") so the links point to the correct anchors.
913106a to
05da0c2
Compare
e5765b8 to
2223322
Compare
2223322 to
6ea8c58
Compare
Description
Type of change
Related Issues
Checklist
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.