fix(account-sdk): require factoryData for undeployed smart accounts - #378
Open
omerbek wants to merge 1 commit into
Open
fix(account-sdk): require factoryData for undeployed smart accounts#378omerbek wants to merge 1 commit into
omerbek wants to merge 1 commit into
Conversation
Collaborator
🟡 Heimdall Review Status
|
omerbek
force-pushed
the
agent/require-factory-data-377
branch
from
August 12, 2026 17:30
ae02cd5 to
8142f08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #377.
What changed
getFactoryArgs()throw a clearBaseErrorwhenfactoryDatais missing.factoryDatapaths.Why
When
factoryDatais undefined, returning{ factory, factoryData: undefined }can silently produce no init code for an undeployed account and defer the failure to bundler/EntryPoint simulation. The SDK cannot safely derive Coinbase Smart Account factory data from only a single owner and owner index, so failing early is safer.Testing
git diff --checkcorepack yarn workspace @base-org/account test createSmartAccountcould not run because the local checkout has no Yarn state/install (Couldn't find the node_modules state file).