chore(L1): pin hinted nitro validator - #394
Merged
Merged
Conversation
Co-authored-by: OpenCode <opencode-noreply@coinbase.com>
Collaborator
✅ Heimdall Review Status
|
jackchuma
previously requested changes
Aug 9, 2026
|
|
||
| remappings = [ | ||
| '@openzeppelin/contracts-upgradeable/=lib/openzeppelin-contracts-upgradeable/contracts', | ||
| 'nitro-validator/=lib/nitro-validator/src/', |
Contributor
There was a problem hiding this comment.
Please no additional remappings. This explicitly goes against our style guide
Contributor
Author
There was a problem hiding this comment.
Removed, thanks! However, I could not find this documented in the repository style guide, do you mean a style guide external to this repo?
I've gone ahead and opened a PR to explicitly add this convention to the AGENTS.md file: #396.
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Thanks! Opens this to help agents to obey the guide: #397
Co-authored-by: OpenCode <opencode-noreply@coinbase.com>
cb-heimdall
dismissed
jackchuma’s stale review
August 9, 2026 22:59
Approved review 4891291207 from jackchuma is now dismissed due to new commit. Re-request for approval.
jackchuma
reviewed
Aug 10, 2026
Co-authored-by: OpenCode <opencode-noreply@coinbase.com>
jackchuma
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base/nitro-validatorat0ea0d12366b4fa44f9e07e4755f2ad36561cb674Testing
just depsjust lint-checkjust forge-buildThis PR intentionally contains only the dependency pin. The deployment and EIP-170 validation are handled in the stacked C2 PR.