Require image_processing 2.2.0 and drop the transform rename

CHANGELOG.md

@@ -56,6 +56,12 @@ Some actions that application developers should consider taking when upgrading f
 
 * An application that uses only the Vips transformer no longer needs the `mini_magick` gem. Previously, `require "active_storage/hot_cell/client"` raised `LoadError` when `mini_magick` was not installed. The gem now loads `Transformers::Image::Magick` when the application first names it.
 
+### ActiveStorage::HotCell::Server
+
+#### Improved
+
+* The transform operations write their output straight to its final path, saving a file rename on every transform. This needs image_processing 2.2.0, which the gemspec now requires. (#4)
+
 ### Tooling
 
 #### Changed

Gemfile.lock

@@ -72,7 +72,7 @@ PATH
   specs:
     activestorage-hotcell-server (0.6.0.dev)
       hotcell-server (= 0.6.0.dev)
-      image_processing (>= 2.1.0)
+      image_processing (>= 2.2.0)
       mini_magick (>= 5.4.0)
       ruby-vips (>= 2.2.1)
 
@@ -144,7 +144,7 @@ GEM
     herb (0.11.0-x86_64-linux-musl)
     i18n (1.15.2)
       concurrent-ruby (~> 1.0)
-    image_processing (2.1.0)
+    image_processing (2.2.0)
     io-console (0.9.4)
     irb (1.18.0)
       pp (>= 0.6.0)
@@ -359,7 +359,7 @@ CHECKSUMS
   hotcell-core (0.6.0.dev)
   hotcell-server (0.6.0.dev)
   i18n (1.15.2) sha256=00f9eb62412fe593b2a65a97daa75300d37abb8f7202ec748e94b6d46a9dd1b5
-  image_processing (2.1.0) sha256=ca3814b1b909fc5fab68b261c50eaffef11e29a6907143e9cf1efc14b6dc6f47
+  image_processing (2.2.0) sha256=e0cb9892a4395ac2b7bb2fac5c6f5bc63361f2f18ed08773e21fce5b111c6974
   io-console (0.9.4) sha256=a403304f32928ee85e56d457b4612ca43f2703b561a3258844992bd24085fbb1
   irb (1.18.0) sha256=de9454a0703a54704b9811a5ef31a60c86949fbf4013fcf244fabc7c775248e3
   json (3.0.2) sha256=8e6d7e7b11384c21230430cef90b71f14849a34a1f4452796670f7c981bd19df

activestorage-hotcell-server/activestorage-hotcell-server.gemspec

@@ -27,7 +27,7 @@ Gem::Specification.new do |spec|
   spec.files = Dir[ "lib/**/*", "MIT-LICENSE", "README.md" ]
 
   spec.add_dependency "hotcell-server", version
-  spec.add_dependency "image_processing", ">= 2.1.0"
+  spec.add_dependency "image_processing", ">= 2.2.0"
   spec.add_dependency "mini_magick", ">= 5.4.0"
   spec.add_dependency "ruby-vips", ">= 2.2.1"
 end

activestorage-hotcell-server/lib/active_storage/hot_cell/server/transforming.rb

@@ -14,15 +14,8 @@ def perform(inputs, outputs, format:, operations: {})
 
           format = format.to_s
 
-          # ImageProcessing chooses its saver from the destination's extension, and a scratch path has none,
-          # so encode to a suffixed sibling on the slot's own scratch and adopt it into place. That is one
-          # rename rather than the copy-out-of-Dir.tmpdir that a destination-less `call` would do, and it
-          # keeps ImageProcessing's own saver — quality, strip, format defaults — rather than reaching past
-          # it to the library, which cannot reproduce those without restating them. Output#post makes the
-          # one remaining copy, out through the caller's descriptor.
-          encoded = destination.path(extension: format)
-          pipeline(source, format, operations).call(destination: encoded)
-          destination.adopt encoded
+          # A scratch path has no extension, so ImageProcessing saves in the `convert` format.
+          pipeline(source, format, operations).call(destination: destination.path)
 
           describe destination.path, format
         end

hotcell-core/lib/hot_cell/descriptors.rb

@@ -140,9 +140,8 @@ class Output < Descriptor
     # the file back out through the descriptor, and an operation that writes the descriptor directly
     # never names one at all.
     #
-    # `extension` names a suffixed sibling on the same scratch instead, for a producer that picks its
-    # saver from the extension (ImageProcessing) or appends one of its own (pdftoppm). The sibling is
-    # not what post ships: adopt renames it into place.
+    # `extension` names a suffixed sibling on the same scratch instead, for a producer that appends an
+    # extension of its own (pdftoppm). The sibling is not what post ships: adopt renames it into place.
     def path(extension: nil)
       base = (@path ||= scratch_path)
       extension.nil? ? base : "#{base}.#{extension}"