Add path http health check ability on before proxy start #95
+217
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
le0pard
commented
Oct 20, 2025
| TargetPort: getEnvInt("TARGET_PORT", defaultTargetPort), | ||
| UpstreamCommand: os.Args[1], | ||
| UpstreamArgs: os.Args[2:], | ||
| UpstreamArgs: append([]string{}, os.Args[2:]...), |
Contributor
Author
There was a problem hiding this comment.
prevent UpstreamArgs mutation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes systems like Heroku start accept traffic if port ready in container. But in reality it is not correct, because
railsmay need more time to start. This PR introduce new config variableHTTP_HEALTH_PATH, which allow to set rails path, which should return 200 http status code. Only after returning 200 status code thruster start proxy on ports. In this case it allow to delay starting port before rails readyShould fix #91