Skip to content

Conversation

@syumai
Copy link

@syumai syumai commented Mar 25, 2025

Add support for exponential backoff using cenkalti/backoff/v5.
Initial backoff duration is 500ms (default value).

@syumai syumai self-assigned this Mar 25, 2025
@syumai syumai requested a review from a team as a code owner March 25, 2025 12:22
@syumai syumai requested review from taro-28 and yebis0942 March 25, 2025 12:22

const (
// PollModeConstant is the mode of polling for query results in constant intervals.
PollModeConstant PollMode = 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iota...?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion on this. In this repository, enum-like constants are typically declared in this form.

ResultModeAPI ResultMode = 0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be an exception, but it is certainly true that either is acceptable in this repository 🙆‍♂️

go-athena/conn.go

Lines 29 to 34 in 7898385

const (
queryTypeUnknown queryType = iota
queryTypeDDL
queryTypeSelect
queryTypeCTAS
)

Copy link
Member

@yebis0942 yebis0942 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@syumai syumai merged commit b64eddf into main Mar 25, 2025
7 checks passed
@syumai syumai deleted the support-exponential-backoff branch March 25, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants