Skip to content

Add support for target_compatible_with to maven_export #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AustinSchuh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for target_compatible_with to maven_export #1396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion private/rules/java_export.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,8 @@ def maven_export(
doc_resources = [],
doc_excluded_packages = [],
doc_included_packages = [],
toolchains = None):
toolchains = None,
target_compatible_with = None):
"""
All arguments are the same as java_export with the addition of:
lib_name: Name of the library that has been built if a library is being exported.
Expand Down Expand Up @@ -261,6 +262,7 @@ def maven_export(
tags = tags + maven_coordinates_tags,
testonly = testonly,
toolchains = toolchains,
target_compatible_with = target_compatible_with,
)

native.filegroup(
Expand All @@ -272,6 +274,7 @@ def maven_export(
visibility = visibility,
tags = tags,
testonly = testonly,
target_compatible_with = target_compatible_with,
)

if not "no-sources" in tags:
Expand All @@ -284,6 +287,7 @@ def maven_export(
visibility = visibility,
tags = tags,
testonly = testonly,
target_compatible_with = target_compatible_with,
)
classifier_artifacts.setdefault("sources", ":%s-maven-source" % name)

Expand All @@ -306,6 +310,7 @@ def maven_export(
visibility = visibility,
tags = tags,
testonly = testonly,
target_compatible_with = target_compatible_with,
toolchains = toolchains,
)
classifier_artifacts.setdefault("javadoc", docs_jar)
Expand All @@ -317,6 +322,7 @@ def maven_export(
pom_template = pom_template,
additional_dependencies = additional_dependencies,
visibility = visibility,
target_compatible_with = target_compatible_with,
tags = tags,
testonly = testonly,
toolchains = toolchains,
Expand All @@ -329,6 +335,7 @@ def maven_export(
artifact = (":%s-maven-artifact" % name) if lib_name else target,
classifier_artifacts = {v: k for (k, v) in classifier_artifacts.items() if v},
visibility = visibility,
target_compatible_with = target_compatible_with,
tags = tags,
testonly = testonly,
toolchains = toolchains,
Expand All @@ -348,6 +355,7 @@ def maven_export(
tags = tags,
visibility = visibility,
toolchains = toolchains,
target_compatible_with = target_compatible_with,
)

# Finally, alias the primary output
Expand All @@ -357,4 +365,5 @@ def maven_export(
visibility = visibility,
tags = tags,
testonly = testonly,
target_compatible_with = target_compatible_with,
)