Add skip-cache-restore option#171
Open
lurtz wants to merge 2 commits into
Open
Conversation
This is useful for rebuilding caches. The current cache restore fallback logic leads to saving only one Github cache for each cache type and never updating it. Over time caches and code start to drift, which requires refreshing caches. With `skip-cache-restore` they can be refreshed if needed.
The content of the repository cache can be influenced by more than MODULE.bazel or the WORKSPACE files. E.g. .bazelversion or files included by MODULE.bazel can either define the version of dependencies or pull in more. As these will eventually land in the lockfile add it to the hash to have different hash values on changes of pulled in dependencies.
Contributor
Author
|
FYI I wondered if it makes sense to treat the repository and disk cache individually, but decided against that. If you think this is useful I can change the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for rebuilding caches. The current cache restore fallback logic leads to saving only one Github cache for each cache type and never updating it. Over time caches and code start to drift, which requires refreshing caches. With
skip-cache-restorethey can be refreshed if needed.Because the repository cache can also change by e.g. changes in
.bazelversion, add the lockfile to avoid hash collisions. Otherwise writing a new cache might fail, even if its content differs.