Repository navigation
Initialise TempFileData and return HspContext members by reference - #982
Merged
bbuchfink merged 1 commit intoSep 24, 2026
Merged
Conversation
…rence TempFileData::fd was left uninitialised on the _MSC_VER branch of open_tmp_file, which returns before assigning it. Default-initialise the struct. The MSVC path opens by name rather than by descriptor, so the value was never dereferenced. HspContext::transcript() and hsp() returned by value, copying the transcript vector and the whole Hsp on every call. Both now return a const reference; the one caller in daa_record.cpp still copies, once. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
bbuchfink
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TempFileData::fd was left uninitialised on the _MSC_VER branch of
open_tmp_file, which returns before assigning it. The struct is now
default-initialised (fd = -1, unlinked = false). The MSVC path opens by name
rather than by descriptor, so the value was never read.
HspContext::transcript() and hsp() returned by value, copying the transcript
vector and the whole Hsp on every call. Both now return a const reference; the
one caller in daa_record.cpp still copies, once.
Builds on v2.2.8 (745cd3b) and passes ctest.
An AI assistant (Claude Code Opus 5.0) assisted with this work.