Skip to content

Conversation

@BrandonSharratt
Copy link

@BrandonSharratt BrandonSharratt commented Oct 25, 2025

Description

Lock the viewing / exporting of versions if you know the form guid and can submit it.
Because other things rely on the existing functionality it will only strip form versions from the api response, and only if the user is passed in and doesn't have requisite permissions

Frontend changes will show an error if the api doesn't return versions in the response

Type of Change

fix (a bug fix)

This is a breaking change because ...
Somethings may be relying on getting the value when it shouldn't be returned and the api will no longer return it

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Further comments

@nimya-aot
Copy link
Contributor

@BrandonSharratt Could you please deploy this PR to the PR environment so the Cypress tests can run and we can confirm that nothing is broken?

@BrandonSharratt BrandonSharratt self-assigned this Nov 5, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 5, 2025

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

@BrandonSharratt
Copy link
Author

BrandonSharratt commented Nov 5, 2025

@BrandonSharratt Could you please deploy this PR to the PR environment so the Cypress tests can run and we can confirm that nothing is broken?

Deployed now @nimya-aot

@nimya-aot
Copy link
Contributor

@BrandonSharratt Could you please deploy this PR to the PR environment so the Cypress tests can run and we can confirm that nothing is broken?

Deployed now @nimya-aot

thanks!

await formStore.getFormPermissionsForUser(properties.f);
} else {
notificationStore.addNotification({
text: t('trans.baseSecure.401UnAuthorizedErrMsg'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this fails, a more appropriate message should be considered. It could be an error message specifically for getFormPermissionsForUser failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants