-
Notifications
You must be signed in to change notification settings - Fork 47
FORMS-1155 lock down form version viewing #1777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
FORMS-1155 lock down form version viewing #1777
Conversation
|
@BrandonSharratt Could you please deploy this PR to the PR environment so the Cypress tests can run and we can confirm that nothing is broken? |
|
|
Release 251d559 deployed at https://chefs-dev.apps.silver.devops.gov.bc.ca/pr-1777 |
Deployed now @nimya-aot |
thanks! |
| await formStore.getFormPermissionsForUser(properties.f); | ||
| } else { | ||
| notificationStore.addNotification({ | ||
| text: t('trans.baseSecure.401UnAuthorizedErrMsg'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this fails, a more appropriate message should be considered. It could be an error message specifically for getFormPermissionsForUser failing.



Description
Lock the viewing / exporting of versions if you know the form guid and can submit it.
Because other things rely on the existing functionality it will only strip form versions from the api response, and only if the user is passed in and doesn't have requisite permissions
Frontend changes will show an error if the api doesn't return versions in the response
Type of Change
fix (a bug fix)
This is a breaking change because ...
Somethings may be relying on getting the value when it shouldn't be returned and the api will no longer return it
Checklist
Further comments