fix: Make file move and DB update atomic for submissions #1785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored moveSubmissionFile to use a transaction, ensuring the file's DB update and move are atomic. The original file is deleted only after a successful commit, and errors during deletion are logged but do not fail the operation. Updated related service and tests to reflect new error handling and atomicity.
jasonchung1871
added
bug
jasonchung1871
requested review from
abhilash-aot,
bhuvan-aot and
usingtechnology
|
Contributor
Author
|
This PR #1791 was recently pushed through which allows for files that are not in the correct location to be checked against the fallback location. This doesn't resolve the issue yet as we don't know what's causing them to be placed in the wrong location. This is still a necessary PR towards determining the cause of the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored moveSubmissionFile to use a transaction, ensuring the file's DB update and move are atomic. The original file is deleted only after a successful commit, and errors during deletion are logged but do not fail the operation. Updated related service and tests to reflect new error handling and atomicity.
https://citz-do.atlassian.net/browse/CCP-2917
Type of Change
Checklist
Further comments