-
Notifications
You must be signed in to change notification settings - Fork 6
ntHash3: otherwise known as BsHash #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jwcodee
wants to merge
38
commits into
master
Choose a base branch
from
bshash_v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Somehow upgrading meson to 1.9 solved the mac issue. Will unpin cmake to retest |
Member
Author
|
@parham-k both cmake and meson have issues with their newest versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@parham-k Can you look into the current MacOS error? There is also a problem with the latest version of meson I believe, I will narrow it down for another PR and maybe get your help on that too when I have isolated which version is creating the problem. In meantime pinning cmake, meson and ninja solves the issues.
Python wrappers will be made after this PR is finalized.
Integrate BShash library, providing two modules: a generic hashing module and a directional module with strand-specific libraries. Also added utilities.