Skip to content

Don't merge deduped entries into existing_entries. #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hoostus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't merge deduped entries into existing_entries. #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions beangulp/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,12 @@ def _extract(ctx, src, output, existing, reverse, failfast, quiet):
extract.sort_extracted_entries(extracted)

# Deduplicate.
deduplicated_new_entries = []
for filename, entries, account, importer in extracted:
importer.deduplicate(entries, existing_entries)
existing_entries.extend(entries)
# We want to deduplicate not just against existing_entries
# but also new entries from other importers in this run
importer.deduplicate(entries, existing_entries + deduplicated_new_entries)
deduplicated_new_entries.extend(entries)

# Invoke hooks.
for func in ctx.hooks:
Expand Down