Allow patterns to have any length (not only 4/bar)#124
Open
manumeter wants to merge 2 commits intobeatboxjs:mainfrom
Open
Allow patterns to have any length (not only 4/bar)#124manumeter wants to merge 2 commits intobeatboxjs:mainfrom
manumeter wants to merge 2 commits intobeatboxjs:mainfrom
Conversation
…ng lengths are handled (index by beat instead of bar)
|
This would be helpful to me. Sometimes one rhythm ends on beat 1 of the next bar (with just one stroke on beat 1), and the next rhythm starts on beat 2 (with an upbeat). So I would represent like this : |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up of: #116
I've invested a bit more time to dig into the source code and find a more elegant and complete way to achieve that goal.
What this commit basically does is that lengths are now not calculated in multiples of bars anymore but in multiples of beats. This makes it even simpler because a lot of
*4and/4could be removed. The player now allows patterns in lengths not devisable by 4, but it still prefers and suggests the 4 beats per bar idea in the UI.I would be very happy if this would be included in the upstream codebase. I'm also happy to adjust it further if you have doubts with this solution. Just let me know.
Thanks :)