Improve lock timeout logging

[Fizzadar]

No description provided.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Summary by CodeRabbit

• Improvements
  • Enhanced lock timeout warning messages with additional context information to provide better diagnostics when retry intervals exceed thresholds.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Walkthrough

Two retry timeout warning log messages in the worker lock handler are enhanced to include additional context. The first message now includes lock_name and lock_key; the second includes lock_names. No control flow or exception handling changes.

Changes

Cohort / File(s)	Change Summary
Worker lock logging enhancements synapse/handlers/worker_lock.py	Updated two non-None retry timeout warning messages to include additional lock context (lock_name/lock_key and lock_names respectively) before the timeout value. No functional logic changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Verify both log messages include correct variable references and formatting
• Confirm message templates are appropriately descriptive for operational debugging
• Ensure no adjacent code logic was inadvertently modified

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch nick/better-lock-timeout-logging

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d362e2b and 20da4f1.

📒 Files selected for processing (1)

• synapse/handlers/worker_lock.py (2 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}