Repository navigation
Use 2 workers for tests in CI - #7150
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change that pins both CI test commands to two xdist workers.
No open issues 🎉
What changed in this PR
CI tests now use two xdist workers across all matrix jobs. Grug sees this avoids the single-worker fallback caused by -k in runs without coverage.
Changes:
- Add
-n2to tests without coverage, keeping the existing test filter. - Add
-n2to tests with coverage.
| File | Description |
|---|---|
.github/workflows/ci.yaml |
Pin both test commands to two xdist workers. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run CI tests on two xdist workers on every matrix job ⚡
-n autolets thepytest_xdist_auto_num_workershook intest/conftest.py:105choose the worker count. That hook drops to a single process whenever-kis passed, so it can keep focused local runs predictable. The "Test without coverage" step runspoe test -k 'not test_convert_rst_to_md', which means 9 of the 10 matrix jobs (every non-main Python on Ubuntu and all the Windows ones) have been running the whole suite serially. This PR pins those jobs to two workers.