Repository navigation
Windows: Retry dependencies installation with backoff - #7151
Merged
Merged
Conversation
Chocolatey install scripts download from upstream hosts such as xiph and SourceForge, which drop connections now and then. Retry each package on its own with exponential backoff instead of retrying the whole batch, so one flaky download no longer fails the entire step. - Add an `Install-ChocoPackage` helper with five attempts and backoff - Install ffmpeg, flac, imagemagick and mp3gain through the helper - Keep the `--allow-empty-checksums` flag for mp3gain only
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the focused change to retry Windows CI dependencies individually.
No open issues 🎉
What changed in this PR
Windows CI now retries each Chocolatey dependency on its own, so brief download failures have more chance to recover before tests start. Grug sees change stays small and focused.
Changes:
- Add shared install function with five attempts and exponential backoff.
- Install packages separately, keeping
mp3gain’s empty-checksum allowance.
| File | Description |
|---|---|
.github/workflows/ci.yaml |
Add per-package Windows dependency retries with increasing delays. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7151 +/- ##
==========================================
- Coverage 80.78% 80.76% -0.02%
==========================================
Files 150 150
Lines 21199 21199
Branches 3238 3238
==========================================
- Hits 17125 17122 -3
- Misses 3257 3260 +3
Partials 817 817 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry each Chocolatey package install on Windows CI 🔁
Windows jobs keep failing before tests even start, because Chocolatey install scripts download from upstream hosts that drop connections now and then. For example, this job failed downloading
flacfromdownloads.xiph.orgwithThe underlying connection was closed. We only retriedmp3gain, andffmpeg,flacandimagemagickwere installed in a singlechoco installcall, so one hiccup killed the whole job.